Tweak a bunch of values #24
Conversation
Sorry for yet another mixed-bag PR, but the more I test around, the better values I find I think. The 'longPress' can be verbalized/explained by 'hold the button and count to three' -> this naturally *almost* works. I decreased the delay from 2000ms to 1800ms, then it works nicely like this with natural counting speed. Also clear up some names.
TokenRat
force-pushed
the
fix/tweak_values
branch
from
ebe7975 to
5729c5e
Compare
There was a problem hiding this comment.
This PR raises the maximum brightness even further. We did all our battery tests with 64% of all LEDs @ 16/255 brightness. LEDs are our primary source of battery drain (stock firmware, no wifi modem enabled).
We now use all LEDs and nearly doubled the maximum brightness, resulting in a roughly 290% increase in power usage in comparison to our battery tests. Those changes already take the badge from roughly a whole convention time down to half a convention at best.
This PR now goes even further by raising the default brightness again by a significant amount, increasing the power drain even more, and therefore further limiting battery life for most people.
I'd strongly advise against merging this change to prevent people from getting sad because their batteries are continuously dying.
The touch timing value updates are fine for me.
|
Added @DunkelRatte because he did the most extensive battery tests iirc |
Sorry for yet another mixed-bag PR, but the more I test around, the better values I find I think.
The 'longPress' can be verbalized/explained by 'hold the button and count to three' -> this naturally almost works. I decreased the delay from 2000ms to 1800ms, then it works nicely like this with natural counting speed. Also clear up some names.